-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bindgen version #130
Bump bindgen version #130
Conversation
Signed-off-by: Gowtham Suresh Kumar <[email protected]>
lib.rs has definitions which were not generated by older bindgen versions. This can now be removed as bindgen 0.63 can generate it automatically. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
The bindgen 0.63.0 version needs callbacks configured as the generated bindings has wrong types. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
The print argument causes the script to fail by passing unnecessary string to the pipe. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
The regenerate_bindings.sh is used to automatically generate the bindings for architectures listed in "targets" variable. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
04be848
to
8e9da11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest it's hard to review such a big change (which is largely autogenerated files) but if it works I think it's good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Some of the generated functions has many arguments which is causing clippy issues. This patch allows the warning. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
Signed-off-by: Gowtham Suresh Kumar [email protected]