Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bindgen version #130

Merged
merged 6 commits into from
Mar 13, 2023
Merged

Conversation

gowthamsk-arm
Copy link
Contributor

Signed-off-by: Gowtham Suresh Kumar [email protected]

Signed-off-by: Gowtham Suresh Kumar <[email protected]>
lib.rs has definitions which were not generated by older bindgen
versions. This can now be removed as bindgen 0.63 can generate it
automatically.

Signed-off-by: Gowtham Suresh Kumar <[email protected]>
The bindgen 0.63.0 version needs callbacks configured as the
generated bindings has wrong types.

Signed-off-by: Gowtham Suresh Kumar <[email protected]>
The print argument causes the script to fail by passing
unnecessary string to the pipe.

Signed-off-by: Gowtham Suresh Kumar <[email protected]>
The regenerate_bindings.sh is used to automatically generate the
bindings for architectures listed in "targets" variable.

Signed-off-by: Gowtham Suresh Kumar <[email protected]>
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest it's hard to review such a big change (which is largely autogenerated files) but if it works I think it's good 👍

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Thanks!

Copy link

@mohamedasaker-arm mohamedasaker-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Some of the generated functions has many arguments which is causing
clippy issues. This patch allows the warning.

Signed-off-by: Gowtham Suresh Kumar <[email protected]>
@gowthamsk-arm gowthamsk-arm merged commit 2ea0eb1 into parallaxsecond:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants